Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker timeout option #330

Closed
wants to merge 2 commits into from
Closed

Conversation

mic47
Copy link
Contributor

@mic47 mic47 commented Jul 15, 2020

Currently when doing graceful shutdown of dramatiq, there is 10 minutes timeout for workers. That means that any worker computing longer than 10 minutes will be terminated. This PR adds an option to set this timeout on command-line, so longer workloads will not be terminated by graceful shutdown.

@mic47 mic47 marked this pull request as draft Jul 15, 2020
@mic47
Copy link
Contributor Author

mic47 commented Jul 15, 2020

For some reason, CI test fails on 600_000 even though I fixed it... [edit: I resolved it by merging commits]

@mic47 mic47 force-pushed the worker_timeout_option branch from 12d53b9 to 82ca296 Compare Jul 15, 2020
@mic47 mic47 marked this pull request as ready for review Jul 15, 2020
@Bogdanp
Copy link
Owner

Bogdanp commented Jul 18, 2020

Thanks! I've renamed the flag to worker-shutdown-timeout for consistency and merged the changes with rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants