Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the worker consumer thread hangs indefinitely when an exception is raised from the message decoder. The consumer does not know how to handle it because the message has not been created yet.
So it enters in the loop:
I tried to follow the suggested approach presented in #284, but I couldn't make it work.
I think the encode side is safe because we can handle exceptions on the publisher side.
--
Note that the PR changes only applies to RabbitMQ broker. For Redis, I used the
JSONEncoder
as a fallback to accessredis_message_id
and rejects the message since it is not available after the exception occurs. But I don't know if it's the right approach.Log from consumer thread