Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncExc thread_id ctype for python >= 3.7 #420

Merged
merged 2 commits into from
Sep 19, 2021

Conversation

FinnLidbetter
Copy link
Contributor

Fixes issue #419

@FinnLidbetter
Copy link
Contributor Author

Ah, apparently sometimes c_ulong(-1) will be 2^32 -1 and the same as c_uint(-1), and others it will be 2^64 - 1 https://docs.python.org/3/library/ctypes.html#ctypes.c_uint

On some operating systems:
  c_ulong(-1) == c_uint(-1) == 2^32 - 1
But on others:
  c_ulong(-1) == 2^64 - 1

For the purpose of the test, use a thread_id that is within the range of
signed int to ensure that the test behaviour is consistent across python
versions and operating systems.
@Bogdanp Bogdanp merged commit d481f56 into Bogdanp:master Sep 19, 2021
@Bogdanp
Copy link
Owner

Bogdanp commented Sep 19, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants