Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for specifying log and PID files #43

Closed
wants to merge 4 commits into from
Closed

Adds support for specifying log and PID files #43

wants to merge 4 commits into from

Conversation

najamansari
Copy link
Contributor

PID files are essential for automated deployments. Similarly, storing logs in a file makes debugging easier (
and as a bonus, you can do log analytics through ELK!).

@Bogdanp
Copy link
Owner

Bogdanp commented Mar 28, 2018

Thanks for contributing this! Make sure you add yourself to the contributors list per the contributing guide. I'll pick this up afterwards and make some minor tweaks as well as add some tests this weekend and then merge it.

@Bogdanp Bogdanp self-requested a review March 28, 2018 05:28
@najamansari
Copy link
Contributor Author

Done!

@Bogdanp
Copy link
Owner

Bogdanp commented Mar 31, 2018

Thanks! I merged your changes with rebase here: 3c8b214...0c8b8f9

I made a few changes to harden the code as well as fix a couple bugs to do w/ logging (the way you had it set up here, logs weren't coalesced in a file so you could end up w/ partial logs).

@Bogdanp Bogdanp closed this Mar 31, 2018
@najamansari
Copy link
Contributor Author

Awesome, I just realized I missed out a couple of important cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants