Skip to content

Allow actors and messages to specify 0 backoff#438

Merged
Bogdanp merged 1 commit into
Bogdanp:masterfrom
FinnLidbetter:allow-zero-backoff
Nov 8, 2021
Merged

Allow actors and messages to specify 0 backoff#438
Bogdanp merged 1 commit into
Bogdanp:masterfrom
FinnLidbetter:allow-zero-backoff

Conversation

@FinnLidbetter

Copy link
Copy Markdown
Contributor

Fixes #388

Tests added to test_actors.py for small diff.

I have a separate branch on top of this locally that refactors all Retries tests from test_actors.py into a new test_retries.py module under tests/middleware. I can make a PR for that refactoring as well if desired.

@FinnLidbetter

Copy link
Copy Markdown
Contributor Author

Looks like CI / test on 3.5 (windows-2016) (pull_request) needs to be removed, since python min version was bumped to 3.6

@Bogdanp

Bogdanp commented Nov 8, 2021

Copy link
Copy Markdown
Owner

Looks good, thanks!

I have a separate branch on top of this locally that refactors all Retries tests from test_actors.py into a new test_retries.py module under tests/middleware. I can make a PR for that refactoring as well if desired.

That would be great.

@Bogdanp Bogdanp merged commit f86b551 into Bogdanp:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retries middleware ignores min_backoff=0 and max_backoff=0 values on messages

2 participants