fix: make sure RabbitMQ broker’s enqueue() attempts the correct number of preset retries#669
Merged
Merged
Conversation
Bogdanp
reviewed
Dec 22, 2024
…r of preset retries
Owner
|
Thanks again! |
Contributor
Author
|
@Bogdanp I stumbled upon this minor bug when I was investigating this: Issue with RabbitMQ Broker: sending a message to the queue creates a consumer thread locally. Could you please take a look? I can open a PR with the proposed solution which works locally, but somehow I’m not too sure if that’s a good solution, it feels a little awkward. |
1 task
LincolnPuzey
added a commit
to LincolnPuzey/dramatiq
that referenced
this pull request
Jul 14, 2025
`attempts` variable is counting the number of attempts made. Once this is >= to the max, raise Exception. Also update log message to make this more obvious
aequitas
pushed a commit
to aequitas/dramatiq
that referenced
this pull request
Nov 17, 2025
`attempts` variable is counting the number of attempts made. Once this is >= to the max, raise Exception. Also update log message to make this more obvious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #668