Fix flushing of RabbitMQ queues#687
Merged
Bogdanp merged 1 commit intoBogdanp:masterfrom Mar 30, 2025
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when queues on the
brokerare flushed.The old behavior was incorrect. It didn't flush delayed queues ending with
.DQand.XQbecause the main queue was in theself.queues_pendingvariable (e.g. undeclared yet). We will have to ensure queues exist by declaring them first.The new behavior doesn't require queues to be declared. If the purge fails and the RabbitMQ server closes the channel, it is recreated again, and the flushing continues.
This PR doesn't come with tests. I was not able to find them for the existing code. Based on that I didn't initiate the discussion as this is only useful in dev/tests environment.