fix: join_queue implementation for compatibility with gevent 25.4.1 - #699
Merged
Conversation
Collaborator
|
This function is only used in the StubBroker so we could theoretically make our own queue that wraps Regarding the current solution, one thing I can think of is naming the thread to make someone's debugging easier. |
Collaborator
Author
|
I've added a thread name, please merge it if you approve. |
Collaborator
|
Looks reasonable to me. At least in dramatiq's own test suite, this is called with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compatibility issues with gevent 25.4.1, released 17th April 2025. See gevent/gevent#2099
The issue caused dramatiq's gevent test suite to fail.