Fix/worker startup timeout

[guedesfelipe]

#701

[guedesfelipe]

I tested it locally and it's working fine.

@synweap15

[synweap15]

hey @guedesfelipe, the tests are now timing out. I have confirmed the behavior in my local environment and lack of this behavior on current master.

Github Actor logging outputs only completed lines, but the issue is in test_cli.py, test_cli_fork_functions_have_no_blocked_signals test.

[guedesfelipe]

What is that param --fork? https://github.com/Bogdanp/dramatiq/blob/master/tests/test_cli.py#L258

[guedesfelipe]

I think the error happens because of the parameter name starting with fork, I changed it to timeout-fork and the test passed:

@synweap15 Do you have a better name suggestion for the parameter?

[synweap15]

Indeed it caused the parameter name to be ambigious. Good find.

I suggest that:

• the parameter gets renamed to --worker-fork-timeout
• move it a few lines up, so it appears above --worker-shutdown-timeout argument definition - so then it's in logical order of fork function -> worker-fork-timeout -> worker-shutdown timeout
• I think I would change the value from seconds to miliseconds - the use of miliseconds is consistent throughout the codebase.

[guedesfelipe]

Make sense! I'll work on it and update the MR ASAP.

[synweap15]

@guedesfelipe could you please address the lint fail?

[guedesfelipe]

Done @synweap15

[synweap15]

@guedesfelipe looking good, thanks!

[guedesfelipe]

Great @synweap15! Do you have any idea when the next release will be out?