Close write_pipe after forking - #707
Merged
Merged
Conversation
The write_pipe never goes out of scope and so the last process's write_pipe is never closed by the watcher process, which results in a hang on read() from this pipe is log_watcher when the worker process is killed, blocking all worker processes when their respective write pipe buffers are exhausted.
|
Looks like a common issue with Python multiprocessing: Interestingly, we do not hit it always, but this was hunting our production for quite some time now :) nice find @dansimko |
Collaborator
|
@dansimko great find. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The write_pipe never goes out of scope and so the last process's write_pipe is never closed by the watcher process, which results in a hang on read() from this pipe in log_watcher when the worker process is killed, and blocking all worker processes when their respective write pipe buffers are exhausted.