feature: log warning when middleware of a given type is added twice#709
Merged
Conversation
| point for where the new middleware should be added. | ||
|
|
||
| If there's already a middleware object of the same class | ||
| added to the broker, it will be replaced. |
Collaborator
There was a problem hiding this comment.
Is this comment correct? The test below asserts that both middlewares of the same type are present ("I expect both middlewares to be added").
Collaborator
Author
There was a problem hiding this comment.
@karolinepauls absolutely, I was testing the described approach on the side and I forgot to replace that comment. Update pushed
Bogdanp
approved these changes
May 27, 2025
optimus-kart
approved these changes
May 28, 2025
karolinepauls
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #708