New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for controlling the overrides of a Symbol #323

Merged
merged 5 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@mathieudutour
Copy link
Contributor

mathieudutour commented Jan 3, 2019

  • add editable property on Override
  • add overrides property on Symbol Master

@mathieudutour mathieudutour changed the title Add support for controlling the overrides of a Symbol Master Add support for controlling the overrides of a Symbol Jan 3, 2019

mathieudutour added some commits Jan 8, 2019

SymbolMaster.define('overrides', {
get() {
// undefined when immutable
if (!this._object.overrideProperies) {

This comment has been minimized.

@bomberstudios

bomberstudios Jan 8, 2019

Collaborator

Is this a typo on this code, or on Sketch?

This comment has been minimized.

@bomberstudios

bomberstudios Jan 8, 2019

Collaborator

(The overrideProperies bit)

This comment has been minimized.

@mathieudutour

mathieudutour Jan 8, 2019

Author Contributor

in sketch. There is even overrideProperiesByCombiningParentsOverrideProperties haha

This comment has been minimized.

@bomberstudios

bomberstudios Jan 8, 2019

Collaborator

¯_(ツ)_/¯

@mathieudutour mathieudutour changed the base branch from develop to release/53 Jan 8, 2019

@mathieudutour mathieudutour merged commit 97e7293 into release/53 Jan 8, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@mathieudutour mathieudutour deleted the f/edit-overrides branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment