Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods to deal with Symbols Page #377

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
4 participants
@WCByrne

This comment has been minimized.

Copy link
Contributor

WCByrne commented Feb 15, 2019

Would it make sense to include a way to create the page that meets these requirement too? For the same reasons that finding it could change (localization) creating it would have the same difficulties.

Essentially a plugin could have

function getOrCreateSymbolsPage(doc) {
    return doc.pages.find(d => d.isSymbolsPage) || Page.symbolsPage({parent: doc})
}

@mathieudutour mathieudutour changed the title [WIP] add isSymbolPage method add isSymbolPage method Mar 5, 2019

@mathieudutour mathieudutour changed the title add isSymbolPage method add methods to deal with Symbols Page Mar 5, 2019

@WCByrne

This comment has been minimized.

Copy link
Contributor

WCByrne commented Mar 5, 2019

Awesome! I will certainly be using this 👏

@christianklotz
Copy link
Contributor

christianklotz left a comment

👍

@mathieudutour mathieudutour merged commit 113b146 into develop Mar 5, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@mathieudutour mathieudutour deleted the f/symbol-page branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.