Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aspectRation property on Gradient #396

merged 4 commits into from Mar 8, 2019


None yet
4 participants
Copy link

mathieudutour commented Feb 27, 2019

No description provided.


This comment has been minimized.

Copy link

bohemian-coding-danger commented Feb 27, 2019


Source/dom/style/Gradient.js changed, but not:

  • 📚 its docs

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

Copy link

christianklotz left a comment

Shouldn't it be aspectRatio, not aspectRation?


This comment has been minimized.

Copy link
Contributor Author

mathieudutour commented Mar 8, 2019

it should indeed haha

mathieudutour added some commits Mar 8, 2019

@mathieudutour mathieudutour merged commit 5e2cf6d into develop Mar 8, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
deploy/netlify Deploy preview ready!

@mathieudutour mathieudutour deleted the f/aspect-ration branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.