Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globals assets can now be mutated #398

Merged
merged 2 commits into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@mathieudutour
Copy link
Contributor

mathieudutour commented Mar 1, 2019

No description provided.

@bohemian-coding-danger

This comment has been minimized.

Copy link
Collaborator

bohemian-coding-danger commented Mar 1, 2019

Warnings
⚠️

Source/dom/WrappedObject.js changed, but not:

  • 🧪 its tests

That's OK as long as you're refactoring.

⚠️

Source/dom/globalAssets.js changed, but not:

  • 📚 its docs

That's OK as long as you're refactoring.

⚠️

Source/dom/utils.js changed, but not:

  • 🧪 its tests

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

@mathieudutour mathieudutour merged commit cea79d8 into develop Mar 8, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@mathieudutour mathieudutour deleted the f/global-assets branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.