Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve console output for selection #432

Merged
merged 2 commits into from Mar 26, 2019

Conversation

Projects
None yet
4 participants
@mathieudutour
Copy link
Contributor

mathieudutour commented Mar 25, 2019

Fix #417

@bohemian-coding-danger

This comment has been minimized.

Copy link
Collaborator

bohemian-coding-danger commented Mar 25, 2019

Warnings
⚠️ This pull request may need a CHANGELOG entry.
⚠️

Source/dom/models/Selection.js changed, but not:

  • 📚 its docs
  • 🧪 its tests

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

@mathieudutour mathieudutour merged commit 4961adc into develop Mar 26, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@mathieudutour mathieudutour deleted the f/better-output-selection branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.