Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix printing the prototype of a wrapped object #451

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@mathieudutour
Copy link
Contributor

commented Apr 4, 2019

Fix #449

To check if an object is a wrapped object, we check for object. _isWrappedObject so we need to define that property only on an instance, and not on the prototype (because the prototype isn't a wrapped object)

@bohemian-coding-danger

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

Warnings
⚠️ This pull request may need a CHANGELOG entry.
⚠️

Source/dom/WrappedObject.js changed, but not:

  • 🧪 its tests

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

@bomberstudios
Copy link
Collaborator

left a comment

Looks good

@mathieudutour mathieudutour merged commit 7448123 into develop Apr 11, 2019

3 of 6 checks passed

Header rules No header rules processed
Details
Pages changed 281 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
ci/circleci Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@mathieudutour mathieudutour deleted the f/fix-printing-prototype branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.