Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return undefined when there is no documents #459

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@mathieudutour
Copy link
Contributor

commented Apr 10, 2019

fix #457

Babel would tranform [nativeDocument] = NSApplication.sharedApplication().orderedDocuments() thinking that it's a proper array but it's not, it's an NSArray so it would throw an error.

@bohemian-coding-danger

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm run install?

⚠️

Source/dom/models/Document.js changed, but not:

  • 📚 its docs
  • 🧪 its tests

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS

@mathieudutour mathieudutour merged commit 6d29761 into develop Apr 12, 2019

3 of 6 checks passed

Header rules No header rules processed
Details
Pages changed 281 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
ci/circleci Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@mathieudutour mathieudutour deleted the f/fix-when-no-documents branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.