Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review: Restrict url scheme to launch a plugin to a specific command (#24181) #460

Merged
merged 5 commits into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@mathieudutour
Copy link
Contributor

commented Apr 10, 2019

Resolve BohemianCoding/Sketch#24181

@mathieudutour mathieudutour changed the base branch from develop to release/55 Apr 15, 2019

@mathieudutour mathieudutour merged commit 20c0e7f into release/55 Apr 18, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@mathieudutour mathieudutour deleted the feature/24181 branch Apr 18, 2019

@WCByrne

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

This is great! Just for clarification:

  1. Does this mean that the url must include a command now?
  2. Will the HandleURL actionable still be called?
@mathieudutour

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

  1. No but if it doesn't, your command won't be called (so kind of yes)
  2. When the URL is like sketch://plugin/my.plugin.identifier/my.command.identifier, yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.