Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent Fill.fillType #463

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@mathieudutour
Copy link
Contributor

commented Apr 11, 2019

Improve consistency by deprecating Fill.fill in favor of Fill.fileType (to match Border.fileType and other types)

@bohemian-coding-danger

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Warnings
⚠️

Source/dom/style/Fill.js changed, but not:

  • 📚 its docs

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS against 509ffdd

@mathieudutour mathieudutour merged commit 4ac5a54 into develop Apr 12, 2019

0 of 6 checks passed

Header rules Deploy failed
Details
Mixed content Deploy failed
Details
Pages changed Deploy failed
Details
Redirect rules Deploy failed
Details
ci/circleci CircleCI is running your tests
Details
deploy/netlify Deploy preview processing.
Details

@mathieudutour mathieudutour deleted the f/consistent-fill-fillType branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.