New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define constant variables for multiple {errors, exceptions} userInfo keys #238

Merged
merged 4 commits into from Mar 17, 2016

Conversation

Projects
None yet
3 participants
@chuganzy
Contributor

chuganzy commented Mar 16, 2016

No description provided.

Takeru Chuganji added some commits Mar 16, 2016

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Mar 16, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@chuganzy chuganzy changed the title from Define constant variables for userInfo keys to Define constant variables for multiple {errors, exceptions} userInfo keys Mar 16, 2016

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Mar 16, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Show outdated Hide outdated Bolts/Common/BFTask.h
@@ -29,6 +29,9 @@ extern NSInteger const kBFMultipleErrorsError;
*/
extern NSString *const BFTaskMultipleExceptionsException;
extern NSString *const BFTaskMultipleErrorsUserInfoKey; // NSArray<NSError *>

This comment has been minimized.

@nlutsenko

nlutsenko Mar 16, 2016

Member

Can we document this the same way as other constants documented?
This will translate in a better auto-generated documentation.

@nlutsenko

nlutsenko Mar 16, 2016

Member

Can we document this the same way as other constants documented?
This will translate in a better auto-generated documentation.

@nlutsenko

This comment has been minimized.

Show comment
Hide comment
@nlutsenko

nlutsenko Mar 16, 2016

Member

Looks great outside of documentation, thanks for doing this.
Will merge when documentation is updated.

Member

nlutsenko commented Mar 16, 2016

Looks great outside of documentation, thanks for doing this.
Will merge when documentation is updated.

Takeru Chuganji
@chuganzy

This comment has been minimized.

Show comment
Hide comment
@chuganzy

chuganzy Mar 17, 2016

Contributor

@nlutsenko Updated the document ⭐️

Contributor

chuganzy commented Mar 17, 2016

@nlutsenko Updated the document ⭐️

Show outdated Hide outdated Bolts/Common/BFTask.h
/*!
An error userInfo key used if there were multiple exceptions on <BFTask taskForCompletionOfAllTasks:>.
Value type is `NSArray<NSException *> *`.

This comment has been minimized.

@nlutsenko

nlutsenko Mar 17, 2016

Member

Nit: There is an extra space between is and type.

@nlutsenko

nlutsenko Mar 17, 2016

Member

Nit: There is an extra space between is and type.

This comment has been minimized.

@chuganzy

chuganzy Mar 17, 2016

Contributor

😱

@chuganzy

chuganzy Mar 17, 2016

Contributor

😱

@nlutsenko

This comment has been minimized.

Show comment
Hide comment
@nlutsenko

nlutsenko Mar 17, 2016

Member

One more nit and it's good to go.

Member

nlutsenko commented Mar 17, 2016

One more nit and it's good to go.

Takeru Chuganji
@nlutsenko

This comment has been minimized.

Show comment
Hide comment
@nlutsenko

nlutsenko Mar 17, 2016

Member

Will merge as soon as Travis passes.

Member

nlutsenko commented Mar 17, 2016

Will merge as soon as Travis passes.

nlutsenko added a commit that referenced this pull request Mar 17, 2016

Merge pull request #238 from hoppenichu/errors_key
Define constant variables for multiple {errors, exceptions} userInfo keys

@nlutsenko nlutsenko merged commit 9067bd0 into BoltsFramework:master Mar 17, 2016

2 checks passed

codecov/project 81.38% (target 75.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nlutsenko nlutsenko added this to the 1.7.0 milestone Mar 29, 2016

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Apr 5, 2016

@hoppenichu updated the pull request.

@hoppenichu updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment