Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeming incompatibility with Foundry v10 or Star Wars FFG for v10 #3

Closed
DenWav opened this issue Jan 22, 2023 · 3 comments · Fixed by #2
Closed

Seeming incompatibility with Foundry v10 or Star Wars FFG for v10 #3

DenWav opened this issue Jan 22, 2023 · 3 comments · Fixed by #2
Labels
bug Something isn't working

Comments

@DenWav
Copy link

DenWav commented Jan 22, 2023

Basic information
  • Pool Party version: 0.8.9
  • Foundry VTT version: 10.291
  • Star Wars FFG version: 1.80-alpha7

Description of the issue

This doesn't seem to work for me on v10, even when I try to use this instead: #2

The issue I'm having doesn't seem to be related to the socket.

Any time I click View on the FFG dice window I get:

ReferenceError: Error thrown in hooked function '' for hook 'closeRollBuilderFFG'. ffgMessageQueue is not defined
[Detected 1 package: ffg-pool-party]
    queueMessage queue-message.ts:4
    <anonymous> pool-party.ts:30
    #call foundry.js:724
    call foundry.js:706
    close foundry.js:5521
    close foundry.js:6224
    onclick roll-builder-hooks.ts:36
    _renderOuter foundry.js:5239
    jQuery 2
        dispatch
        handle
    onError foundry.js:747
    call_wrapped libWrapper-wrapper.js:507
    <anonymous> listeners.js:134
    onError#0 libWrapper-wrapper.js:187
    #call foundry.js:728
    call foundry.js:706
    close foundry.js:5521
    close foundry.js:6224
    onclick roll-builder-hooks.ts:36
    _renderOuter foundry.js:5239
    jQuery 2
        dispatch
        handle

ReferenceError: An error occurred while rendering RollSelectorForm 202. ffgDicePools is not defined
[Detected 1 package: ffg-pool-party]
    getData roll-selector-form.ts:21
    _render foundry.js:5108
    _render foundry.js:5822
    render foundry.js:5067
    openSelectorForm roll-selector-form.ts:83
    onclick roll-builder-hooks.ts:35
    _renderOuter foundry.js:5239
    jQuery 2
        dispatch
        handle
    onError foundry.js:747
    call_wrapped libWrapper-wrapper.js:507
    <anonymous> listeners.js:134
    onError#0 libWrapper-wrapper.js:187
    render foundry.js:5069

And when I click Share I get this error:

Uncaught ReferenceError: ffgMessageQueue is not defined
[Detected 4 packages: ffg-pool-party, system:starwarsffg, lib-wrapper, ffg-star-wars-enhancements]
    queueMessage queue-message.ts:4
    onclick roll-builder-hooks.ts:16
    _renderOuter foundry.js:5239
    jQuery 9
        dispatch
        handle
        add
        Ee
        each
        each
        Ee
        on
        n
    _renderOuter foundry.js:5236
    setTimeout handler*_renderOuter foundry.js:5235
    _render foundry.js:5125
    _render foundry.js:5822
    render foundry.js:5067
    displayRollDialog dice-helpers.js:109
    call_wrapped libWrapper-wrapper.js:507
    register_hooks ffg-star-wars-enhancements.js:170
    call_wrapper libWrapper-wrapper.js:616
    displayRollDialog#0 libWrapper-wrapper.js:189
    <anonymous> swffg-main.js:445
    jQuery 2
        dispatch
        handle
    queueMessage queue-message.ts:4
    onclick roll-builder-hooks.ts:16
    _renderOuter foundry.js:5239
    jQuery 9
        dispatch
        handle
        (Async: EventListener.handleEvent)
        add
        Ee
        each
        each
        Ee
        on
        n
    _renderOuter foundry.js:5236
    (Async: setTimeout handler)
    _renderOuter foundry.js:5235
    InterpretGeneratorResume self-hosted:1819
    AsyncFunctionNext self-hosted:807
    (Async: async)
    _render foundry.js:5125
    InterpretGeneratorResume self-hosted:1819
    AsyncFunctionNext self-hosted:807
    (Async: async)
    _render foundry.js:5822
    render foundry.js:5067
    displayRollDialog dice-helpers.js:109
    call_wrapped libWrapper-wrapper.js:507
    call_wrapped self-hosted:1518
    register_hooks ffg-star-wars-enhancements.js:170
    InterpretGeneratorResume self-hosted:1819
    AsyncFunctionNext self-hosted:807
    (Async: async)
    call_wrapper libWrapper-wrapper.js:616
    displayRollDialog#0 libWrapper-wrapper.js:189
    <anonymous> swffg-main.js:445
    jQuery 2
        dispatch
        handle

In both cases the dice roll window disappears. I can click the dice icon to open it again and repeat. I'm not noticing any other issues.

Additional contact info

Discord: DenWav#1989

@DenWav DenWav added the bug Something isn't working label Jan 22, 2023
@RandomGiblet
Copy link

I have the same issue with the same error when clicking on View. Just wanted to make sure you knew it was not just your instance.

@DenWav
Copy link
Author

DenWav commented May 27, 2023

Okay revisiting this I do see the linked PR #2 does fix this - not sure why it didn't work the first time. Probably was just a cache not serving the updated files.

@Szyna1988

This comment was marked as off-topic.

@BoltsJ BoltsJ linked a pull request Sep 24, 2023 that will close this issue
@BoltsJ BoltsJ closed this as completed in #2 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants