Skip to content

Piotr Boniecki
Bonias

  • Joined on Jun 15, 2009

Organizations

@galdomedia
May 16, 2016
Bonias commented on pull request prograils/lit#72
@Bonias

The code is updated, but I think my first comment still applies here. I don't think 401 status can be returned here (although I'm not completely su…

May 16, 2016
Bonias commented on pull request prograils/lit#74
@Bonias

Looks good for me.

May 11, 2016
Bonias commented on pull request prograils/lit#72
@Bonias

Lit::SourcesController seems fine.

May 11, 2016
Bonias commented on pull request prograils/lit#71
@Bonias

Maybe synchronization works that way right now, but if we change synchronization to get only updated records (using is_changed flag) then we will g…

May 11, 2016
Bonias commented on pull request prograils/lit#72
@Bonias

I'm still not convinced :) But now I see this works differently than I thought at beginning. Have you tested it with two servers with two different…

May 11, 2016
Bonias commented on pull request prograils/lit#72
@Bonias

Are you sure that this error appears when user provides wrong api key? I don't think /sync_complete returns such error.

May 11, 2016
Bonias commented on pull request prograils/lit#72
@Bonias

activejob supports globalID (http://edgeguides.rubyonrails.org/active_job_basics.html#globalid) so AR object is fine.

May 11, 2016
Bonias opened issue prograils/lit#73
@Bonias
Translation keys from active record validation errors does not appear in web UI
May 11, 2016
Bonias commented on pull request prograils/lit#71
@Bonias

I'm wondering: we have is_changed flag at the moment. I think this flag means that translation was updated at web UI. If I'm right that we don't ne…

May 11, 2016
Bonias commented on pull request prograils/lit#70
@Bonias

Isn't it redundant? Transactions at store_translations and load_translations_to_cache are not enough?

May 11, 2016
Bonias commented on pull request prograils/lit#70
@Bonias

I don't know if it affects performance, but there is not need to open transaction when if check returns false. You can do this like that: if store_…

May 10, 2016
Bonias opened pull request piesync/tox#3
@Bonias
Stringify Numeric, TrueClass and FalseClass types on render
1 commit with 49 additions and 1 deletion
May 6, 2016
Bonias pushed to master at prograils/lit
@Bonias
May 6, 2016
Bonias merged pull request prograils/lit#69
@Bonias
Use travis containers to fix: undefined method 'spec' for nil:NilClass
1 commit with 5 additions and 0 deletions
May 6, 2016
Bonias opened pull request prograils/lit#69
@Bonias
Use travis containers to fix: undefined method 'spec' for nil:NilClass
1 commit with 5 additions and 0 deletions
May 6, 2016
@Bonias
  • @Bonias 03fdc63
    Use travis containers to fix: undefined method 'spec' for nil:NilClass
May 6, 2016
@Bonias
  • @Bonias 869aeda
    Use travis containers to fix: undefined method 'spec' for nil:NilClass
Bonias created branch travis-fix at prograils/lit
May 6, 2016
Apr 15, 2016
Bonias opened issue piesync/tox#2
@Bonias
Stringify numbers, true, and false values
Apr 4, 2016
@Bonias
  • 1070d69
    Send croped file to server
Bonias created branch master at Bonias/cropper-app
Apr 4, 2016
Bonias created repository Bonias/cropper-app
Apr 4, 2016
Mar 21, 2016
Bonias commented on pull request piesync/tox#1
@Bonias

Done

Mar 21, 2016
@Bonias
  • @Bonias 1c57703
    Fix render with additional attributes (not defined at template)
Mar 21, 2016
Bonias opened pull request piesync/tox#1
@Bonias
Fix render with additional attributes (not defined at template)
1 commit with 23 additions and 0 deletions
Mar 21, 2016
@Bonias
  • @Bonias 8823334
    Fix render with additional attributes (not defined at template)
Mar 21, 2016
Mar 17, 2016
Something went wrong with that request. Please try again.