New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page jumps to start when trying to edit code block #1162

Closed
salimnanji opened this Issue Dec 7, 2018 · 7 comments

Comments

3 participants
@salimnanji
Copy link

salimnanji commented Dec 7, 2018

Trying to edit a code block after scrolling down in a page.

As soon as I click the code block to edit (first click of double click), the cursor jumps back up to the first line of the page. This is happening in all my pages regardless of number of code blocks or how large they are.

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Dec 9, 2018

Hi @salimnanji, Sorry to hear you're experiencing an issue.

Could you provide any further detail?:

  • What version of BookStack you're experiencing this on?
  • What page editor are you using? (WYSIWYG or Markdown)
  • What browser are you finding this issue on?
@salimnanji

This comment has been minimized.

Copy link
Author

salimnanji commented Dec 10, 2018

@ssddanbrown Thanks. Details:

  • BookStack v0.24.3
  • WYSIWYG
  • Google Chrome Version 68.0.3440.106 (Official Build) (32-bit), 71.0.3578.80 (Official Build) (64-bit)

Works in IE.

@aditya-aggarwal-1

This comment has been minimized.

Copy link

aditya-aggarwal-1 commented Jan 4, 2019

Can confirm, breaking on Google Chrome (Official Latest) as well as Safari. No logs in JS Console.

@salimnanji

This comment has been minimized.

Copy link
Author

salimnanji commented Jan 10, 2019

@ssddanbrown were you able to recreate this bug? Still happening for me:
Google Chrome Version Version 69.0.3497.100 (Official Build) (32-bit)

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 11, 2019

@salimnanji Not before but just had another look and now understand this.

Steps to reproduce

  1. Create a new page with lots of content (In height) at start of page.
  2. Add a code block to the bottom.
  3. Click code block, See editor cursor jump to top.

Will try to fit into the next release or at least one soon after.

@ssddanbrown ssddanbrown added this to the v0.25.0 milestone Jan 11, 2019

ssddanbrown added a commit that referenced this issue Jan 12, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 12, 2019

Fix now found and in code, Ready for next release. Thanks for reporting!

@salimnanji

This comment has been minimized.

Copy link
Author

salimnanji commented Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment