New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Block, SQL: SQL commands aren't recognized #1181

Closed
steffenmaechtel opened this Issue Dec 14, 2018 · 1 comment

Comments

2 participants
@steffenmaechtel
Copy link

steffenmaechtel commented Dec 14, 2018

Code Block, SQL: SQL commands aren't recognized by CodeMirror (javascript library) and hence, they aren't highlighted correctly.

Example mark up:
<span role="presentation" style="padding-right: 0.1px;">FROM fe_users u</span>

Comparisons:

1) CodeMirror: SQL demonstration
https://codemirror.net/1/contrib/sql/

key word: "join"
<span class="sql-keyword">join </span>

2) CodeMirror: SQL Mode for CodeMirror
https://codemirror.net/mode/sql/

key word: FROM
<span class="cm-keyword">FROM</span>

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Dec 16, 2018

Thanks for reporting @steffenmaechtel.

Just need to tweak the mode used. Fix will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment