Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of Shelves menu item with custom permissions #1201

Closed
Bolthier opened this Issue Dec 29, 2018 · 2 comments

Comments

2 participants
@Bolthier
Copy link

Bolthier commented Dec 29, 2018

Describe the bug
The visibility of the Shelves menu item is dependent only on global permission of a user role. With custom permissions only set to View for the same user role the menu item doesn't show up.

Steps To Reproduce

  1. Go to user role Public and deactivate all default permissions for Shelves.
  2. Activate the View custom permission for a Shelve for user role Public.
    2
  3. Log out and see no Shelves menu item.
    1

Expected behavior
A tab for the Shelves if you have custom permissions for View on specific shelves even without any default permissions.

Or an option in Settings or Users where you can activate or deactivate the button.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): BookStack v0.24.2
  • PHP Version: 7.2
  • Hosting Method (Nginx/Apache/Docker): Apache2

Additional context
See also: #1171 (comment)

@Bolthier Bolthier changed the title Visibility of Shelves menut item dependent only on default permission Visibility of Shelves menu item dependent only on default permission Dec 29, 2018

@Bolthier Bolthier changed the title Visibility of Shelves menu item dependent only on default permission Visibility of Shelves menu item with custom permissions Dec 29, 2018

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.25.1 milestone Jan 1, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 1, 2019

@Bolthier Good find, Thanks for reporting.

Has very similar functionality requirements as #1199.

@ssddanbrown ssddanbrown modified the milestones: v0.25.1, v0.25.2 Jan 20, 2019

@ssddanbrown ssddanbrown self-assigned this Mar 9, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 9, 2019

Patch applied to master, Will be in the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.