New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Date Localization in Version Overview #1214

Closed
Reflic opened this Issue Jan 11, 2019 · 3 comments

Comments

2 participants
@Reflic
Copy link

Reflic commented Jan 11, 2019

Describe the bug
In the Overview of the versions / revisions of one article the date is shown in an locale format for US and not for the language which has been set.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Set language on something which is not English.
  2. Create a page and some versions.
  3. Go to Versions Overview.

Expected behavior
The date should be formatted in the locale which has been specified in the settings.

Screenshots
bug

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): v0.24.3
  • PHP Version: 7.2
  • Hosting Method (Nginx/Apache/Docker): Nginx
@Reflic

This comment has been minimized.

Copy link
Author

Reflic commented Jan 11, 2019

I thought of working on this bug, but after some look on the code the topic of Date and Time Localization is not considered much (Which i can fully understand...).
The diffToHuman things are working quite good.

But i think here is some more plan needed. (Will take another bug in order to make it my first contribution 😆 )

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 12, 2019

Thanks for raising @Reflic. Both date formats in your screenshot use the same library but for the format in question it looks like some extra configuration is required or some system changes are needed.

Marked to be looked into for next patch release.

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 19, 2019

Now implemented to be in the next release.
Will need a documentation update since the relevant locales will need to be installed on the host system.

For documentation update

Locales for the language will need to be installed.
For ubuntu, this can be done via the following:

# Select your locales
dpkg-reconfigure locales 

# Restart any php processes
sudo systemctl restart php7.2-fpm.service 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment