Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUA Language #1223

Closed
DevKurka opened this Issue Jan 17, 2019 · 14 comments

Comments

4 participants
@DevKurka
Copy link

DevKurka commented Jan 17, 2019

Describe the feature you'd like
I'd really appreciated if more code languages (such as Lua which is important for me) could be released.

Describe the benefits this feature would bring to BookStack users
I think that there are so much people using languages others than these already setupped.

Additional context
I think that it wont be hard adding more if framework already exists.

Thanks for help!

@Mant1kor

This comment has been minimized.

Copy link
Contributor

Mant1kor commented Jan 17, 2019

Does markdown-editor not support lua?

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Jan 17, 2019

Not for me at least. I've updated to the latest version anyways

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 17, 2019

Codemirror supports lua, So support could easily be added, but it might be best to evaluate the cost of including loads of different languages, and perhaps look at different ways of loading them if required.

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Jan 17, 2019

I tried to add it on my own but it failed at the end so.

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Jan 18, 2019

@ssddanbrown Any tips about loading them manually or information if this can be worked on?

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 2, 2019

This has now been added, Will be in the next patch release.

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Mar 2, 2019

@ssddanbrown Hey! Thanks. Any clue when the patch release will be on?

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 2, 2019

@DevKurka I have a rough target of next weekend as a target for the patch release. No guarantees though.

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Mar 2, 2019

@ssddanbrown Is there any way to get it installed before it's released?

@Nico207

This comment has been minimized.

Copy link

Nico207 commented Mar 7, 2019

I made the same changes as the commit e471d0c
Adding a block of Lua code does nothing more, the text remains blank.
image

Should I do something more.

I tried on other languages, with the same result (white text)

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Mar 7, 2019

@Nico207 Can reproduce. Had the same issue and that's the only one reason why I am waiting for the update.

@DevKurka

This comment has been minimized.

Copy link
Author

DevKurka commented Mar 7, 2019

@ssddanbrown Any tip for that?

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 7, 2019

@Nico207 @DevKurka Changes the JS files have to be built via node (Details in the readme).

If you don't want to do that but really need this, Here's a zip of the built JS from the current master branch. Can can try extracting the contained file out to public/dist/app.js. Can't guarantee stability though since this is from a development branch.
app.zip

Otherwise, Will just have to wait for the release.

Changing the files in the commit, or following the above, is not really supported and can cause conflicts on updating BookStack.

@Nico207

This comment has been minimized.

Copy link

Nico207 commented Mar 11, 2019

Thanks for the zip file.
In my case, I don't really need the Lua language. My goal was mainly to understand how to activate other languages (in my case, VB and Pascal), and see if it was simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.