Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shortcut used for markdown drawing manager to be cross-platform #1228

Closed
abulgatz opened this issue Jan 18, 2019 · 3 comments

Comments

2 participants
@abulgatz
Copy link

commented Jan 18, 2019

Is there any way to delete a draw.io drawing?

Maybe they can appear in the list of images or attachments on a page?

I also recommend a draw.io page in the documentation that explains how to edit a drawing by double-clicking on it in the wysiwyg editor or the markdown preview.

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Jan 19, 2019

Hi @abulgatz,

There is a drawing manager which can be accessed in the WYSIWYG editor by clicking here:

image

In the markdown editor I think it can be accessed by Ctrl+Clicking the "Insert drawing" link.

@abulgatz

This comment has been minimized.

Copy link
Author

commented Jan 19, 2019

Thanks, "Ctrl + Click" drawing manager works, but only on Windows.

On a Mac, "Ctrl + Click" is interpreted by the OS as a right click and so doesn't work.

Can a different modifier key be used, either for all OS's, or recognize a mac and change to "Command + Click" just on the Mac?

@abulgatz

This comment has been minimized.

Copy link
Author

commented Jan 19, 2019

in /resources/assets/js/components/markdown-editor.js line 63, changing:

if (action === 'insertDrawing' && event.ctrlKey) {

to

if (action === 'insertDrawing' && (event.ctrlKey || event.metaKey)) {

Should allow "Command + Click" to function on a Mac.

@ssddanbrown ssddanbrown added this to the v0.26.0 milestone Apr 14, 2019

@ssddanbrown ssddanbrown changed the title Any way to delete a draw.io drawing? Update shortcut used for markdown drawing manager to be cross-platform Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.