Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild front-end translation system #1258

Closed
ssddanbrown opened this issue Feb 4, 2019 · 3 comments

Comments

@ssddanbrown
Copy link
Member

commented Feb 4, 2019

Just putting this as a reminder to myself really.

Need to cleanup front-end translation system (/translations endpoint).
It's a badly-done system, inefficient system.

Instead only the translations used should land in the browser. Insert those via standard tags then parse out with standard JS. Translations could be defined near where but have blade stacks gather these into a common location.

@ezzra

This comment has been minimized.

Copy link

commented Feb 5, 2019

Instead only the translations used should land in the browser.

I dont understand that very well, isn't that the case already? The textes are translated in backend when the html file is generated, arent they?

@ssddanbrown

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@ezzra Yeah, This is more for translation used inside of JavaScript components which is handled on the front-end, differently to the majority of the translations which are inserted within the back-end blade files.

@ezzra

This comment has been minimized.

Copy link

commented Feb 5, 2019

Ah ok, I totally missed the front-end and was confused :)

@ssddanbrown ssddanbrown added this to the v0.27.0 milestone Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.