Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add a redis password #1283

Closed
msbt opened this Issue Feb 18, 2019 · 3 comments

Comments

@msbt
Copy link

msbt commented Feb 18, 2019

Describe the bug
When using redis as cache/session driver, one might need to add a password for the redis connection, there is no variable in the config or any mention in the db file

Steps To Reproduce
Steps to reproduce the behavior:

  1. Change drivers to redis
  2. Look for the place to put the password

Expected behavior
Either have a REDIS_PASSWORD variable or use something like REDIS_SERVERS=:${REDIS_PASSWORD}@${REDIS_HOST}:${REDIS_PORT}

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): v0.25.1
  • PHP Version: 7.2
  • Hosting Method (Nginx/Apache/Docker): apache in a docker container behind nginx reverse proxy

Additional context
Hope I didn't miss something

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Feb 19, 2019

Hope I didn't miss something

No, Just don't used redis that often myself so did not know it could be commonly used with a password.

Thanks for reporting, Should be a fairly quick thing so have marked for the next minor release.

@msbt

This comment has been minimized.

Copy link
Author

msbt commented Feb 20, 2019

Great, thanks!

@ssddanbrown ssddanbrown self-assigned this Mar 8, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 8, 2019

The new format will be HOST:PORT:DATABASE:PASSWORD, Where :PASSWORD is optional.
Just about to merge in the code updates for this, Will be in the next patch release.

Notes for release

Previously specifying multiple redis servers did not actually seem to do anything, Only the first was used. Code is now updated to auto-use a cluster if more than one server is provided.

The REDIS_CLUSTER env option has now been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.