Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Pictures permission with copy paste not set #1287
Describe the bug
Steps To Reproduce
Your Configuration (please complete the following information):
So image permissions are a little complex as visibility will depend on configuration, context and permissions.
By default in BookStack, for performance reasons, images are put into public space where auth is not required. You can alternatively configure this to store such images in a local folder that's not within public space (
Context & Permissions
As mentioned in the roles screen when selecting image permissions, view permissions are controlled by the assets they are uploaded to. This visibility primarily is in reference to the list shown in the image manager.
General access visibility, when an image is used in a page or copied across pages, is not checked since this level of permission checking would require a fair bit of extra complexity when page content is shown.
Perhaps we need to update the wording used in the roles view to clarify this.
As i wrote, the permission system for images is working fine. But only when you upload the pictures with "Insert a Image" and then upload the image with "Drop images or click here to upload".
When you just copy the image and paste it directly into your text, the permission system is not working.