Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate Storage Types for Images and Attachments #1302

Closed
Zeigren opened this issue Feb 28, 2019 · 3 comments

Comments

@Zeigren
Copy link

commented Feb 28, 2019

In setting up a secure Bookstack instance there's a bit of a wrinkle when it comes to secure images. Since secure images are only available with STORAGE_TYPE=local_secure you're stuck with hosting all attachments locally as well.

I don't know if it's possible to do secure images over S3 so the next best thing would be to have separate storage types.

arigathanks gozaimuch

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Thanks @Zeigren for the suggestion.

I think secure images over a network call (to S3) would cause trouble due to the rapid nature of image access when using the system.

Being able to define a separate storage system for attachments is a good idea though, and something I imagine would be useful to many others.
Shouldn't be too hard to implement so have marked it for the next feature release. I'm going to update the issue title to focus on the separate storage types, Hope that's okay.

@ssddanbrown ssddanbrown changed the title [Request] Secure Images for S3 and/or Seperate Storage Types for Images and Attachments Seperate Storage Types for Images and Attachments Feb 28, 2019

@ssddanbrown ssddanbrown modified the milestones: v0.26.0, v0.27.0 May 5, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Moving this out by a feature release, Due to the current release already being overdue and large in scope. Next release cycle should be a fair bit quicker than the current though.

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

Now included in master to be in the next release.
Variables will be as per the below example .env snippet.

If you're changing an existing storage_type in use, you'll need to migrate your content first to the new storage system. The docs detail locations of files for various storage systems:
https://www.bookstackapp.com/docs/admin/upload-config/

# Image storage system to use
# Defaults to the value of STORAGE_TYPE if unset.
# Accepts the same values as STORAGE_TYPE.
STORAGE_IMAGE_TYPE=local
# Attachment storage system to use
# Defaults to the value of STORAGE_TYPE if unset.
# Accepts the same values as STORAGE_TYPE although 'local' will be forced to 'local_secure'.
STORAGE_ATTACHMENT_TYPE=local_secure

Thanks again for the feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.