Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom name attribute in LDAP #1306

Closed
craftbyte opened this Issue Mar 2, 2019 · 3 comments

Comments

3 participants
@craftbyte
Copy link

craftbyte commented Mar 2, 2019

Describe the feature you'd like
I would like to be able to set the name attribute in LDAP just like I can set the mail attribute. We use a Windows AD server and the actual names are mostly stored in the displayName attribute instead of cn.

Describe the benefits this feature would bring to BookStack users
This would allow BookStack to be used in environments where the name attribute is not cn.

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 7, 2019

Thanks for the suggestion @craftbyte, I can see how this would be useful.
I have assigned this to be done for the next feature release.

Note for reference

LdapService@getUserDetails, Copy setup for email attribute.

@dfanara

This comment has been minimized.

Copy link
Contributor

dfanara commented Mar 9, 2019

I've worked on the changes for this issue, but I'm having issues with the unit tests.

I haven't been able to get the tests on the master branch to pass, so I haven't started writing tests for this feature. I'm running phpunit version 6.5.14, setup the bookstack-test databases and ran the migrations.

The majority of the tests are failing with errors similar to this:

Expected status code 200 but received 419.
Failed asserting that false is true.

Is this expected behavior on the master branch?

Edit: I got the unit tests to pass, I think I just needed to clear the config cache.

@ssddanbrown ssddanbrown modified the milestones: v0.26.0, v0.25.2 Mar 10, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 10, 2019

Functionality now implemented as per #1317. Will be in the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.