Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow custom name attribute in LDAP #1306
Describe the feature you'd like
Describe the benefits this feature would bring to BookStack users
I've worked on the changes for this issue, but I'm having issues with the unit tests.
I haven't been able to get the tests on the master branch to pass, so I haven't started writing tests for this feature. I'm running phpunit version 6.5.14, setup the bookstack-test databases and ran the migrations.
The majority of the tests are failing with errors similar to this:
Is this expected behavior on the master branch?
Edit: I got the unit tests to pass, I think I just needed to clear the config cache.