Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Confirmation In Restore Function #1321

Closed
Bolthier opened this issue Mar 10, 2019 · 1 comment

Comments

2 participants
@Bolthier
Copy link

commented Mar 10, 2019

Describe the bug
When using the restore function no confirmation query is shown before restore. While not a problem of its own the link is written into the browser history and can be activated accidently without knowing that you're about to restore a page into an older state.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Create page with all permissions with this user.
  2. Update the page once.
  3. Use the restore function and restore the first revision.
  4. Look in your browser history and click on the entry.
  5. Page is restored without confirming it.

Expected behavior
A clear confirmation before restoring a revision.

Screenshots
2019 03 10-18 59

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): BookStack v0.25.1
  • PHP Version: 7.2.10
  • Hosting Method (Nginx/Apache/Docker): Apache 2

@ssddanbrown ssddanbrown added this to the v0.26.0 milestone Mar 10, 2019

@ssddanbrown ssddanbrown self-assigned this Mar 10, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Thanks for reporting @Bolthier, I agree with this, This should be a POST/PUT/PATCH request instead of a GET request to prevent it even being in the history.

I have assigned to myself for the next release as it would be good to do this as part of the design update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.