Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the user profile form, Roles with a dot in the name do not remember their input on validation failure #1325

Closed
tpoindessous opened this issue Mar 11, 2019 · 2 comments

Comments

2 participants
@tpoindessous
Copy link

commented Mar 11, 2019

Hi

I got hit by a small bug but an unpleased one, as it takes me long time to figure it out.

Describe the bug
I made a new user : I checked one role for this user and I mistyped the password and the password-confirm didn't match. When I save my user, page is refreshed, error message is displayed but the role is unchecked. I did several tests and I can reproduce it : it seems that this bug occurred because :

  • I checked the last role of the list
  • OR because my role contains a dot "Client.NAME"

Steps To Reproduce
Steps to reproduce the behavior:

  1. Go to '/settings/users/create'
  2. Fill name and email
  3. Check the last role, which contains a dot in his name
  4. Mistype password and password-confirm so they don't match
  5. Save user

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): BookStack v0.25.1

Thanks !

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Thanks for reporting @tpoindessous.

I've confirmed this to occur when a dot is part of the role name. I'll update the issue name to be more specific based on the results that I've found.

@ssddanbrown ssddanbrown added this to the v0.26.0 milestone Mar 12, 2019

@ssddanbrown ssddanbrown changed the title Bug: Add new user : User roles are forget if the password-confirm and password don't match On the user profile form, Roles with a dot in the name do not remember their input on validation failure Mar 12, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Fixed by @cw1998 in #1392, Fix will be deployed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.