Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a Test Email results in 500 error if not configured correctly #1874

Closed
rickr opened this issue Feb 5, 2020 · 2 comments
Closed

Send a Test Email results in 500 error if not configured correctly #1874

rickr opened this issue Feb 5, 2020 · 2 comments

Comments

@rickr
Copy link

@rickr rickr commented Feb 5, 2020

Describe the bug
When incorrectly configured the Send a Test Email returns a generic 500 error.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Ensure your email is not configured (eg set MAIL_HOST in .env to example.com)
  2. Go to 'Settings'
  3. Click on 'Maintenance'
  4. Click on 'Send A Test Email'
  5. See error

Expected behavior
A helpful toast or error page should be displayed.

In my instance I had to look at the laraval log in order to find the following log entry:
production.ERROR: Connection could not be established with host smtp.dreamhost.org

Something similar should be displayed instead of a generic 500 error.

Screenshots
N/A

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings):
    BookStack v0.28.0
  • PHP Version:
  • Hosting Method (Nginx/Apache/Docker):
    Linuxserver Docker

Additional context
N/A

@ssddanbrown

This comment has been minimized.

Copy link
Member

@ssddanbrown ssddanbrown commented Feb 6, 2020

Well I guess the feature kind of works 😅

But yeah, we should probably catch any errors off the send, if we're not doing so, and report them back. Thanks for reporting.

@ssddanbrown

This comment has been minimized.

Copy link
Member

@ssddanbrown ssddanbrown commented Feb 15, 2020

Thanks again for reporting @rickr.

A fix has now been applied to be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.