New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Tab Indenting in editor #346

Closed
nh-mike opened this Issue Mar 23, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@nh-mike

nh-mike commented Mar 23, 2017

Hi,

Currently, when inserting code into the TinyMCE Editor, the only compatible indenting is by using spaces. I am unsure whether the TinyMCE Editor supports this, but it would be nice if we could indent using the tab bar.

Thanks.

@nh-mike

This comment has been minimized.

Show comment
Hide comment
@nh-mike

nh-mike Apr 4, 2017

Hi,

I have commenced working on doing this myself and will create a merge request once I am happy with this, as I believe that this may be useful for many people.

I have started adding my code to resources\assets\js\directives.js but I have no experience with Angular, so progress is slow. At this point, I have it adding the indent and it saves nicely but it moves the caret to the beginning of the editor content and does not yet work with pasted text.

Also, I only intend for this to work inside code boxes.

I am happy to continue to see this through until I am happy with it.

Cheers.

nh-mike commented Apr 4, 2017

Hi,

I have commenced working on doing this myself and will create a merge request once I am happy with this, as I believe that this may be useful for many people.

I have started adding my code to resources\assets\js\directives.js but I have no experience with Angular, so progress is slow. At this point, I have it adding the indent and it saves nicely but it moves the caret to the beginning of the editor content and does not yet work with pasted text.

Also, I only intend for this to work inside code boxes.

I am happy to continue to see this through until I am happy with it.

Cheers.

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.17 milestone Jul 1, 2017

@ssddanbrown ssddanbrown added the Bug label Jul 2, 2017

@ssddanbrown

This comment has been minimized.

Show comment
Hide comment
@ssddanbrown

ssddanbrown Jul 2, 2017

Member

@nh-mike Thanks for confirming this issue and offering to attempt to fix this. This is now fixed as of 968e7b8 as part of the new code editing features. It will be released as part of the upcoming v0.17 release. Therefore I will go ahead and close this issue.

Member

ssddanbrown commented Jul 2, 2017

@nh-mike Thanks for confirming this issue and offering to attempt to fix this. This is now fixed as of 968e7b8 as part of the new code editing features. It will be released as part of the upcoming v0.17 release. Therefore I will go ahead and close this issue.

@ssddanbrown ssddanbrown closed this Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment