New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken page with emoji in source #405

Closed
zizzfizzix opened this Issue May 31, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@zizzfizzix

zizzfizzix commented May 31, 2017

  • BookStack Version: 0.16.2
  • PHP Version: 7.1
  • MySQL Version: mysql Ver 15.1 Distrib 10.0.30-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
Used snippet
class ErrorHandler {
    static func handleError(code: Int) -> String {
        "Handle error with code: \(code) 😡".log()
        switch code {
        case 400:
            return "Invalid data!".localized
        case 401:
            FlowManager.logout()
            return "You are not authorized!".localized
        case 403:
            return "Access denied!".localized
        case 404:
            return "Not found!".localized
        default:
            return "Something went wrong! Please try again.".localized
        }
    }
}
Expected Behavior

Emoji in the page content

Actual Behavior

see:
screencapture-wiki-codeaddict-io-books-dev-playbook-page-error-handler-1496246314891

@ssddanbrown

This comment has been minimized.

Show comment
Hide comment
@ssddanbrown

ssddanbrown Jun 4, 2017

Member

@zizzfizzix Thanks for reporting, TIL that the default UF8 MySQL charset will just cut off when encountering emoji.

In the next release, Will update the default MySQL collation to support emoji and will convert content-holding tables such as the pages, books, revisions and chapters.

Member

ssddanbrown commented Jun 4, 2017

@zizzfizzix Thanks for reporting, TIL that the default UF8 MySQL charset will just cut off when encountering emoji.

In the next release, Will update the default MySQL collation to support emoji and will convert content-holding tables such as the pages, books, revisions and chapters.

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.17 milestone Jul 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment