New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system fonts instead of Roboto #423

Closed
ssddanbrown opened this Issue Jul 2, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@ssddanbrown
Member

ssddanbrown commented Jul 2, 2017

Just an idea at the moment. Done it for a lot of recent projects and have seen some other large apps go the same way. I've been pretty happy with my own results.

Advantages

  • More consistent with user system UI.
  • System fonts likely to render cleaner.
  • Removes font download, Saves time and kb.

Disadvantages

  • Less consistency across users and devices.
@ls42

This comment has been minimized.

Show comment
Hide comment
@ls42

ls42 Jul 3, 2017

I'd prefer system fonts / consistency with user system UI.

Although making the font-family CSS param configurable through the system settings would even better, if that's possible. Making it possible to switch between sans-serif and serif fonts.

ls42 commented Jul 3, 2017

I'd prefer system fonts / consistency with user system UI.

Although making the font-family CSS param configurable through the system settings would even better, if that's possible. Making it possible to switch between sans-serif and serif fonts.

@the4ndy

This comment has been minimized.

Show comment
Hide comment
@the4ndy

the4ndy Jul 3, 2017

Is there a current (easy ish) way to change the font for the whole app (ie via a config file or something)? If so, 1) i would love to know where this is, and 2) I think that should be adequate, maybe allow users to upload the font or choose the font from a list at the same place they put their branding image in.

But that said, I agree, system fonts is likely the way to go.

the4ndy commented Jul 3, 2017

Is there a current (easy ish) way to change the font for the whole app (ie via a config file or something)? If so, 1) i would love to know where this is, and 2) I think that should be adequate, maybe allow users to upload the font or choose the font from a list at the same place they put their branding image in.

But that said, I agree, system fonts is likely the way to go.

@domainzero

This comment has been minimized.

Show comment
Hide comment
@domainzero

domainzero Jul 5, 2017

@the4ndy You can currently override the font by specifying a stylesheet or style in the Custom HTML Head section on the settings page.

I am personally overwriting the monospace font with Hack for laughs, so it's doable.

domainzero commented Jul 5, 2017

@the4ndy You can currently override the font by specifying a stylesheet or style in the Custom HTML Head section on the settings page.

I am personally overwriting the monospace font with Hack for laughs, so it's doable.

@nh-mike

This comment has been minimized.

Show comment
Hide comment
@nh-mike

nh-mike Jul 7, 2017

I personally like the Roboto font. I'm a bit of an Android fanboy so there's no way I could prefer the system font. It would be nice if maybe this were in it's own stylesheet or something so that it is easy for the end user to modify, but I wouldn't lose sleep if the Roboto font were dropped from the project.
I guess if it were easily configurable to the end user, they could specify their own fonts (although that may lead to some ugly Bookstack instances, what does that matter here?) and would be a pretty cool addition.

nh-mike commented Jul 7, 2017

I personally like the Roboto font. I'm a bit of an Android fanboy so there's no way I could prefer the system font. It would be nice if maybe this were in it's own stylesheet or something so that it is easy for the end user to modify, but I wouldn't lose sleep if the Roboto font were dropped from the project.
I guess if it were easily configurable to the end user, they could specify their own fonts (although that may lead to some ugly Bookstack instances, what does that matter here?) and would be a pretty cool addition.

@ssddanbrown

This comment has been minimized.

Show comment
Hide comment
@ssddanbrown

ssddanbrown Jul 10, 2017

Member

Thanks everyone for your input. Looks like there's a general sway to system fonts. Will probably look to make that change in the next release then.

I agree about being able to customize. @domainzero makes a good point about using the custom HTML setting that's already there. I'd say maybe have a guide in the official docs about how to set a custom font with some examples otherwise system fonts are default.

Might need to review the current SASS files minimize font definitions in css rules as much as possible to make overriding simple.

Will probably use approach B from this guide since it's served me well before.

Member

ssddanbrown commented Jul 10, 2017

Thanks everyone for your input. Looks like there's a general sway to system fonts. Will probably look to make that change in the next release then.

I agree about being able to customize. @domainzero makes a good point about using the custom HTML setting that's already there. I'd say maybe have a guide in the official docs about how to set a custom font with some examples otherwise system fonts are default.

Might need to review the current SASS files minimize font definitions in css rules as much as possible to make overriding simple.

Will probably use approach B from this guide since it's served me well before.

@ssddanbrown ssddanbrown added the Design label Jul 10, 2017

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.18 milestone Aug 1, 2017

ssddanbrown added a commit that referenced this issue Aug 19, 2017

Removed included fonts, Set to use system fonts.
All font definitions moved into _text.scss.
Needs override documentation to complete.
Relates to #423.

ssddanbrown added a commit to BookStackApp/website that referenced this issue Aug 26, 2017

@ssddanbrown

This comment has been minimized.

Show comment
Hide comment
@ssddanbrown

ssddanbrown Aug 26, 2017

Member

Fonts have now been changed in master branch, Documentation updated in preparation. Both will be deployed with v0.18

Member

ssddanbrown commented Aug 26, 2017

Fonts have now been changed in master branch, Documentation updated in preparation. Both will be deployed with v0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment