Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar scrolling difficult and inconsistent at mid-range sceen size breakpoints #4394

Closed
1 task done
LawssssCat opened this issue Jul 23, 2023 · 2 comments
Closed
1 task done

Sidebar scrolling difficult and inconsistent at mid-range sceen size breakpoints #4394

LawssssCat opened this issue Jul 23, 2023 · 2 comments
Labels
🐛 Bug 💻 Front-End 💆 UX

Comments

@LawssssCat
Copy link
Contributor

LawssssCat commented Jul 23, 2023 •
edited by ssddanbrown

Describe the feature you'd like

add a max_height attirbute to Page Navigation

Details

ccc

Describe the benefits this would bring to existing BookStack users

No need to scroll to the end of the page to see the content of Page Navigation beyond the screen.

Can the goal of this request already be achieved via other means?

..

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?

6 months to 1 year

Additional context

BookStack v23.06.2
@ssddanbrown
Copy link
Member

Thanks for reporting @LawssssCat, I'm going to reclassify this as a front-end bug since the behaviour is misaligned with full desktop view.

Note for my future reference: This is specific to the medium screen breakpoint range, where there's a single left-hand sidebar.

@ssddanbrown ssddanbrown changed the title Page Navigation cannot be scrolled when its height is out of the screen Sidebar scrolling difficult and inconsistent at mid-range sceen size breakpoints Jul 23, 2023
@LawssssCat LawssssCat mentioned this issue Sep 19, 2023
Merged
ssddanbrown added a commit that referenced this issue Oct 6, 2023
@ssddanbrown
Layout: Restructured tri-layout for sidebar control
0310677 
Restructured tri-layout grid system, so the sidebars are contained in
their own child grid system, mimicking the parent grid, so we can treat
them as part of the same parent scroll container at smaller screen
sizes for consistent scroll/sticky behavior.

Tested on Firefox, Chromium, Gnome Web and Safari (MacOS).

For #4394
Changes made during review of #4562
@ssddanbrown
Copy link
Member

Now addressed as of merge of #4562, and follow-up commit of 0310677.
Will be part of the next feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 💻 Front-End 💆 UX
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssddanbrown @LawssssCat