Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of Contents Indenting #542

Closed
Ethanb00 opened this issue Oct 3, 2017 · 2 comments

Comments

@Ethanb00
Copy link

commented Oct 3, 2017

I'm calling this a bug request, but I'm not sure if it is actually a bug

For Bug Reports

  • BookStack Version: 18.1
  • PHP Version: PHP7
Expected Behavior

On the left-hand table of contents, I would expect a standard way that headers stack under each other. Whether it is a static indent corresponding to the number of #s or whether it is indented on the basis of "this section has fewer #s than the last section so it goes in one indent value"

Current Behavior

Presently, I had a section with a 2 # header (i.e. ## Title), followed by a 6 hash header (i.e. ######) in a page with several other headers. However, the table of contents did not accurately reflect the page structure. See image:
2017-10-03 12_37_08-on-boarding procedure _ techops docs

As you can see the section titled "Preceding the creation....." should fall below (i.e. indent under) "Documenting Account Information"

I hope that makes sense. I was having trouble explaining this so I am happy to try to clarify if needed.

Thank you!

@ssddanbrown ssddanbrown added this to the v0.27.0 milestone May 6, 2019

@ssddanbrown

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Hi @Ethanb00,
Sorry it's taken 20 months for a response 😅.

The previous logic for shifting headers (When only smaller ones were used) was off. Now fixed with a test to cover. Will be in the next release.

@Ethanb00

This comment has been minimized.

Copy link
Author

commented Jun 17, 2019

I know how it goes sometimes! Thanks for the fix! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.