Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow social login to create new accounts if registration is disabled #574
This is related to #572
In a business setting you may want to have registrations disabled but still allow new users to sign in/create accounts using SSO that is limited to a specific domain.
SSO is enabled.
A new user attempts to sign on using SSO. The user account is automatically created.
New users are unable to create accounts using company SSO when registration is disabled.
Steps to Reproduce
Enable SSO (ie Google)
This is also somewhat related to #477.
My concern with this is that I'd like to support environments where registration is fully disabled but where SSO is used.
Maybe, instead of allowing registration when registration is enabled, This issue should be re-focused to something along the lines of
@ssddanbrown I think this could be an important feature to have.
As part of a company, I want all my coworkers to be able to authenticate themselves using Google (with the domain of the company). If they login with Google and the user does not exist => a new user is created. If the user exists => we log him in.
For external users, I want to be able to create users with the right Role using the admin settings and set an email/password for them to access authorized books.
So if we simply add the option to automatically sign up users authnticated with Google for the first time, it could cover all use cases:
I also would like to take this opportunity to thank you for this project. It's amazing and very helpful
This was referenced
Aug 16, 2018
As of commit e60d11e this behaviour should now be possible.
Using Google, for example, setting:
Will be in the next release due within the next few days. Therefore I'll close this issue.