New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desired Feature: Ability to remove particular revisions #784

Closed
jsreynolds opened this Issue Apr 4, 2018 · 6 comments

Comments

3 participants
@jsreynolds

jsreynolds commented Apr 4, 2018

For Feature Requests

Desired Feature: Ability to remove revisions

Expected Behavior

Ability to remove a particular revision - for security reasons for example where someone has pasted in code or notes which contain private information and saved. Make a change, it still lives on in a revision.

Current Behavior

Revisions are unable to be removed.

Steps to Reproduce

Edit a page, see the revision

@Abijeet

This comment has been minimized.

Member

Abijeet commented May 21, 2018

Hi @ssddanbrown,

I'd like to take a crack at this. I guess adding a Delete option here next to Restore would work?

screenshot-2018-5-21 page revisions for examples of different bookstack

I'll look further into the technical complexities involved with this.

@jsreynolds

This comment has been minimized.

jsreynolds commented May 24, 2018

That looks like a great idea to me; thank you for considering it.

@Abijeet Abijeet self-assigned this Jun 10, 2018

@Abijeet

This comment has been minimized.

Member

Abijeet commented Aug 5, 2018

Hey @ssddanbrown, Let me know if my comments here sound okay, and I'll get started on this.

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Aug 6, 2018

@Abijeet Ah, Sorry I missed this, Yeah sounds good!

Abijeet added a commit that referenced this issue Sep 16, 2018

Merge pull request #1008 from BookStackApp/revision-deletion
#784 - Adds ability to remove particular revision.
@Abijeet

This comment has been minimized.

Member

Abijeet commented Sep 16, 2018

This has been added in PR #1008 and will be in the next release.

@Abijeet Abijeet closed this Sep 16, 2018

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.24.0 milestone Sep 16, 2018

@jsreynolds

This comment has been minimized.

jsreynolds commented Sep 20, 2018

Just wanted to say thank you - really looking forward to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment