New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export doesn't show user-edited styles #981

Closed
Vicvinegar0 opened this Issue Aug 22, 2018 · 3 comments

Comments

3 participants
@Vicvinegar0

Vicvinegar0 commented Aug 22, 2018

Is there a way to get the PDF export to include the CSS changes that I've added? In my case I've changed the line spacing (via changing the margins on the p and h elements) and the font color to black with different font-family. However these changes don't show when exported to PDF (wkhtmltopdf).
Edit: same issue with export to HTML

@derek-shnosh

This comment has been minimized.

derek-shnosh commented Aug 22, 2018

This is on my short-list of requests as well, thanks for posting.

@ssddanbrown

This comment has been minimized.

Member

ssddanbrown commented Aug 23, 2018

Thanks @Vicvinegar0 for reporting this. Should be a simple one to implement so will mark to be in the next release.

@derek-shnosh

This comment has been minimized.

derek-shnosh commented Oct 5, 2018

@ssddanbrown I know this is closed, but figured this was the best place to ask.

Thanks for implementing this! I'm wondering if there is any way to get the export to render the CodeMirror theme.

Also, it seems that any callouts with MD formatting in them are rendered properly by bookstack, but any space characted leading the MD annotation are replaced/omitted from the PDF export.

Example;

Code from markdown editor;

<c><p class="callout info">Static route statements will not affect traffic for VL-192 clients until SVI is migrated; i.e. the *attached* route on the Resort Cores for the associated subnet will supersede the configured static routes.</p>
  • Note: This comment explains why the <c> is included before the <p class...> for the callout; in short, it is a workaround to get markdown formatting to work inside a callout.

Bookstack Render

image

PDF Export Render

image

  • Notice the missing space between the attached; I initially thought this was due to italics, but it affected bold formatting as well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment