Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd option to disable LDAPS Certificate Validation #1096
Conversation
christophert
added some commits
Oct 27, 2018
ssddanbrown
modified the milestones:
BookStack Beta v0.24.2,
BookStack Beta v0.25.0
Nov 4, 2018
ssddanbrown
added
🛠 Enhancement
🏭 Back-End
labels
Nov 10, 2018
This comment has been minimized.
This comment has been minimized.
|
@christophert Thanks for offering this pull request. Have set for next feature release. Will require a minor update to the required PHP version for BookStack due to the |
This comment has been minimized.
This comment has been minimized.
lucassmacedo
commented
Dec 11, 2018
|
Nice!! |
ssddanbrown
merged commit 7c8edf5
into
BookStackApp:master
Dec 22, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
ssddanbrown
added
the
📖 Docs Update
label
Dec 22, 2018
This comment has been minimized.
This comment has been minimized.
|
Docs update PR submitted as well: BookStackApp/website#32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
christophert commentedOct 27, 2018
This PR allows users to set
LDAP_TLS_INSECUREin their.envto bypass LDAP TLS Certificate Verification. This is useful for development environments that may not have a trusted CA certificate for LDAP functionality.