New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable LDAPS Certificate Validation #1096

Merged
merged 3 commits into from Dec 22, 2018

Conversation

3 participants
@christophert
Copy link
Contributor

christophert commented Oct 27, 2018

This PR allows users to set LDAP_TLS_INSECURE in their .env to bypass LDAP TLS Certificate Verification. This is useful for development environments that may not have a trusted CA certificate for LDAP functionality.

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Nov 10, 2018

@christophert Thanks for offering this pull request. Have set for next feature release.

Will require a minor update to the required PHP version for BookStack due to the LDAP_OPT_X_TLS_REQUIRE_CERT constant only being available in 7.0.5 and above as per details here.

@lucassmacedo

This comment has been minimized.

Copy link

lucassmacedo commented Dec 11, 2018

Nice!!

@ssddanbrown ssddanbrown merged commit 7c8edf5 into BookStackApp:master Dec 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@christophert

This comment has been minimized.

Copy link
Contributor Author

christophert commented Dec 22, 2018

Docs update PR submitted as well: BookStackApp/website#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment