New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom avatar provider like Libravatar or self-hosted service #1111

Merged
merged 1 commit into from Dec 22, 2018

Conversation

2 participants
@Vinrobot
Copy link
Contributor

Vinrobot commented Nov 8, 2018

This PR fixes JavaScript build process with the new NPM dependencies and adds the possibility to use a different user avatar service like Libravatar.

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Nov 9, 2018

Thanks for the pull request @Vinrobot.

After merging, I think I'll go through the existing wording and functions in the code and essentially 'de-gravatar' all areas to make them generic 'avatar' wording instead but with gravatar still as a default. Just warning now as I'll probably reduce and re-name some of the env variable names.

Just one thing, Could you remove and changes that relate to the build process? Will make this request neater and I've just gone through and applied a more longer-term fix by updating all modules to standard ES6 import/export syntax which has caused conflicts with this. I know it's 100% my bad though for leaving the build process broken. Feel free to open on a new pull request if needed.

Since this a a new feature and since I might break an old .env var this will be targeted for the next feature release rather than being in the next minor release.

@Vinrobot Vinrobot force-pushed the Vinrobot:custom-avatar-provider branch 2 times, most recently from c9007ed to d92491b Nov 10, 2018

@Vinrobot Vinrobot force-pushed the Vinrobot:custom-avatar-provider branch from d92491b to 5e6c039 Nov 10, 2018

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.25.0 milestone Nov 10, 2018

@Vinrobot

This comment has been minimized.

Copy link
Contributor Author

Vinrobot commented Nov 10, 2018

Hello @ssddanbrown,

I removed the two commits related to the build process.

@ssddanbrown ssddanbrown merged commit 5e6c039 into BookStackApp:master Dec 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ssddanbrown added a commit that referenced this pull request Dec 22, 2018

Abstracted user avatar fetching away from gravatar
Still uses gravatar as a default.
Updated URL placeholders to follow LDAP format.
Potential breaking config change: `GRAVATAR=false` replaced by `AVATAR_URL=false`
Builds upon #1111
@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Dec 22, 2018

Now merged, ready for the next release.

Just so you're aware after updating, I have changed some of the config for this:

  • GRAVATAR_URL will now be AVATAR_URL
  • Placeholders will now use a $ instead of a % in the format, So: ${hash} ${size} ${email}. This is just to align it with some other BookStack options that have placeholders.

Details of changes are in b56fc21.
Thanks again @Vinrobot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment