New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a default timeout of 60 seconds to dropzone. #1133

Merged
merged 1 commit into from Dec 22, 2018

Conversation

2 participants
@Abijeet
Copy link
Member

Abijeet commented Nov 17, 2018

Fixes #876

@Abijeet Abijeet requested a review from ssddanbrown Nov 17, 2018

@Abijeet

This comment has been minimized.

Copy link
Member Author

Abijeet commented Nov 17, 2018

Also has a documentation update here - BookStackApp/website#31

@Abijeet Abijeet changed the title Added a default timeout of 60 seconds to dropzone. Adds a default timeout of 60 seconds to dropzone. Nov 24, 2018

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.25.0 milestone Nov 30, 2018

@ssddanbrown ssddanbrown merged commit d3d3e2a into master Dec 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

ssddanbrown added a commit that referenced this pull request Dec 22, 2018

@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Dec 22, 2018

@Abijeet Thanks for implementing this.

Have changed the variable name to uploadTimeout in f62843c so we can reuse the variable elsewhere if needed and it allows us to swap out dropzone if needed.

Also, I updated the error handling so the preview item in the dropzone shows as complete&errored & shows the error instead of having an app notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment