New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor link on the "View Profile" & Add "register" to nav. #1146

Merged
merged 2 commits into from Jan 5, 2019

Conversation

2 participants
@qianmengnet
Copy link
Contributor

qianmengnet commented Nov 26, 2018

  1. Add 3 anchor link to "Created Content" on the "View Profil
    e" page and click to jump to the page section

  2. Add "register" to nav.You need to click "login" to find register, which is not convenient for people who are not familiar with the app.

qianmengnet added some commits Nov 26, 2018

Add anchor link to "Created Content" on the "View Profile"
Add 3 anchor link to "Created Content" on the "View Profile" page and click to jump to the page section
Add "register" to nav.
Add "register" to nav.You need to click "login" to find register, which is not convenient for people who are not familiar with the app.

@qianmengnet qianmengnet changed the title Add anchor link to "Created Content" on the "View Profile" Add anchor link on the "View Profile" & Add "register" to nav. Nov 26, 2018

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.25.0 milestone Dec 19, 2018

@ssddanbrown ssddanbrown merged commit 3c796b1 into BookStackApp:master Jan 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ssddanbrown added a commit that referenced this pull request Jan 5, 2019

Tweaked profile page anchor links and swapped register/login links
Also added test for login/register links on non-auth app view
Relates to #1146
@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Jan 5, 2019

Thanks @qianmengnet for this pull request. Now merged, ready to be in the next release.
Made a few tweaks in 70ad707 just to the wording/ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment