Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tooltip on the image manager. #1238

Merged
merged 1 commit into from Mar 8, 2019

Conversation

2 participants
@Abijeet
Copy link
Member

Abijeet commented Jan 27, 2019

Fixes #1186

image

image

  1. I've added a message.
  2. The tooltip arrow now appears slightly off-center. I think that's an acceptable trade-off.

@Abijeet Abijeet self-assigned this Jan 27, 2019

@Abijeet Abijeet requested a review from ssddanbrown Jan 27, 2019

@Abijeet Abijeet added this to the v0.25.2 milestone Jan 27, 2019

@@ -210,7 +210,6 @@ body.flexbox-support #entity-selector-wrap .popup-body .form-group {

.image-manager-sidebar {
width: 300px;
margin-left: 1px;

This comment has been minimized.

@Abijeet

Abijeet Jan 27, 2019

Author Member

Not sure why this was there. Adds a bit of gap which I think doesn't look very good.

@ssddanbrown ssddanbrown merged commit 9dba9ca into master Mar 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssddanbrown

This comment has been minimized.

Copy link
Member

ssddanbrown commented Mar 8, 2019

Thanks @Abijeet, I agree with the removal of the random margin.

Now merged! It did look a little odd with the shifted arrow so I updated the arrow position a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.